linux-kernel - Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4474831c-a8f6-496e-8348-a10e3fb7c798@pereznus.es>
Date: Wed, 19 Mar 2025 17:26:59 +0100
From: Sergio Pérez <sergio@...eznus.es>
To: Krzysztof Kozlowski <krzk@...nel.org>, linux-iio@...r.kernel.org
Cc: tduszyns@...il.com, jic23@...nel.org, lars@...afoo.de, robh@...nel.org,
 conor+dt@...nel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO


El 19/03/2025 a las 9:46, Krzysztof Kozlowski escribió:
> On 18/03/2025 18:37, Krzysztof Kozlowski wrote:
>>> I've now run the tool correctly on my patch file and have fixed the
>>> identified issues:
>>> - Removed trailing whitespace
>>> - Fixed lines exceeding 79 characters
>>> - Fixed the inconsistency between the description and example for
>>> reset-gpios
>>> - Modified the existing example instead of adding a new one
>>> - Ensured proper line endings and formatting
>>> - Used proper get_maintainers.pl to include all recipients
>>>
>> Please read the guides carefully. The process is extremely simple as:
>>
>> git add ...
>> git commit --signed-off
>> git format-patch -v3 -2
>> scripts/chekpatch.pl v3*
>> scripts/get_maintainers.pl --no-git-fallback v3*
>> git send-email *
> Please read this again. I gave you detailed instruction which you still
> decided not to follow. The instructions are quite precise on purpose,
> because other method leads to wrong patchset - broken that or other way.
>
I transcribe exactly the commands I have executed:

$ git add Documentation/devicetree/bindings/iio/light/bh1750.yaml

$ git commit --signed-off

$ git add drivers/iio/light/bh1750.c

$ git commit --signed-off

$ git format-patch -v3 -2

$ scripts/checkpatch.pl v3*
---------------------------------------------------------------
v3-0001-dt-bindings-iio-light-bh1750-Add-reset-gpios-prop.patch
---------------------------------------------------------------
total: 0 errors, 0 warnings, 17 lines checked

v3-0001-dt-bindings-iio-light-bh1750-Add-reset-gpios-prop.patch has no obvious style problems and is ready for submission.
---------------------------------------------------------------
v3-0002-iio-light-bh1750-Add-hardware-reset-support-via-G.patch
---------------------------------------------------------------
total: 0 errors, 0 warnings, 47 lines checked

v3-0002-iio-light-bh1750-Add-hardware-reset-support-via-G.patch has no obvious style problems and is ready for submission.

$ scripts/get_maintainer.pl --no-git-fallback v3*
Tomasz Duszynski <tduszyns@...il.com> (maintainer:ROHM BH1750 AMBIENT 
LIGHT SENSOR DRIVER,in file)
Jonathan Cameron <jic23@...nel.org> (maintainer:IIO SUBSYSTEM AND DRIVERS)
Lars-Peter Clausen <lars@...afoo.de> (reviewer:IIO SUBSYSTEM AND DRIVERS)
Rob Herring <robh@...nel.org> (maintainer:OPEN FIRMWARE AND FLATTENED 
DEVICE TREE BINDINGS)
Krzysztof Kozlowski <krzk+dt@...nel.org> (maintainer:OPEN FIRMWARE AND 
FLATTENED DEVICE TREE BINDINGS)
Conor Dooley <conor+dt@...nel.org> (maintainer:OPEN FIRMWARE AND 
FLATTENED DEVICE TREE BINDINGS)
linux-iio@...r.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS)
devicetree@...r.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE 
TREE BINDINGS)
linux-kernel@...r.kernel.org (open list)

$ git_send_email v3*
v3-0001-dt-bindings-iio-light-bh1750-Add-reset-gpios-prop.patch
v3-0002-iio-light-bh1750-Add-hardware-reset-support-via-G.patch
(mbox) Adding cc: Sergio Perez <sergio@...eznus.es> from line 'From: 
Sergio Perez <sergio@...eznus.es>'
(body) Adding cc: Sergio Perez <sergio@...eznus.es> from line 
'Signed-off-by: Sergio Perez <sergio@...eznus.es>'

From: Sergio Perez <sergio@...eznus.es>
To: Tomasz Duszynski <tduszyns@...il.com>,
         Jonathan Cameron <jic23@...nel.org>,
         Lars-Peter Clausen <lars@...afoo.de>,
         Rob Herring <robh@...nel.org>,
         Krzysztof Kozlowski <krzk+dt@...nel.org>,
         Conor Dooley <conor+dt@...nel.org>,
         linux-iio@...r.kernel.org,
         devicetree@...r.kernel.org,
         linux-kernel@...r.kernel.org
Cc: Sergio Perez <sergio@...eznus.es>
Subject: [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios 
property
Date: Wed, 19 Mar 2025 17:11:16 +0100
Message-ID: <20250319161117.1780-1-sergio@...eznus.es>
X-Mailer: git-send-email 2.43.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

     The Cc list above has been expanded by additional
     addresses found in the patch commit message. By default
     send-email prompts before sending whenever this occurs.
     This behavior is controlled by the sendemail.confirm
     configuration setting.

     For additional information, run 'git send-email --help'.
     To retain the current behavior, but squelch this message,
     run 'git config --global sendemail.confirm auto'.

Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll): y
OK. Log says:
Server: smtp.mail.me.com
MAIL FROM:<sergio@...eznus.es>
RCPT TO:<tduszyns@...il.com>
RCPT TO:<jic23@...nel.org>
RCPT TO:<lars@...afoo.de>
RCPT TO:<robh@...nel.org>
RCPT TO:<krzk+dt@...nel.org>
RCPT TO:<conor+dt@...nel.org>
RCPT TO:<linux-iio@...r.kernel.org>
RCPT TO:<devicetree@...r.kernel.org>
RCPT TO:<linux-kernel@...r.kernel.org>
RCPT TO:<sergio@...eznus.es>
From: Sergio Perez <sergio@...eznus.es>
To: Tomasz Duszynski <tduszyns@...il.com>,
         Jonathan Cameron <jic23@...nel.org>,
         Lars-Peter Clausen <lars@...afoo.de>,
         Rob Herring <robh@...nel.org>,
         Krzysztof Kozlowski <krzk+dt@...nel.org>,
         Conor Dooley <conor+dt@...nel.org>,
         linux-iio@...r.kernel.org,
         devicetree@...r.kernel.org,
         linux-kernel@...r.kernel.org
Cc: Sergio Perez <sergio@...eznus.es>
Subject: [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios 
property
Date: Wed, 19 Mar 2025 17:11:16 +0100
Message-ID: <20250319161117.1780-1-sergio@...eznus.es>
X-Mailer: git-send-email 2.43.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Result: 250
(mbox) Adding cc: Sergio Perez <sergio@...eznus.es> from line 'From: 
Sergio Perez <sergio@...eznus.es>'
(body) Adding cc: Sergio Perez <sergio@...eznus.es> from line 
'Signed-off-by: Sergio Perez <sergio@...eznus.es>'

From: Sergio Perez <sergio@...eznus.es>
To: Tomasz Duszynski <tduszyns@...il.com>,
         Jonathan Cameron <jic23@...nel.org>,
         Lars-Peter Clausen <lars@...afoo.de>,
         Rob Herring <robh@...nel.org>,
         Krzysztof Kozlowski <krzk+dt@...nel.org>,
         Conor Dooley <conor+dt@...nel.org>,
         linux-iio@...r.kernel.org,
         devicetree@...r.kernel.org,
         linux-kernel@...r.kernel.org
Cc: Sergio Perez <sergio@...eznus.es>
Subject: [PATCH v3 2/2] iio: light: bh1750: Add hardware reset support 
via GPIO
Date: Wed, 19 Mar 2025 17:11:17 +0100
Message-ID: <20250319161117.1780-2-sergio@...eznus.es>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20250319161117.1780-1-sergio@...eznus.es>
References: <20250319161117.1780-1-sergio@...eznus.es>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll): y
OK. Log says:
Server: smtp.mail.me.com
MAIL FROM:<sergio@...eznus.es>
RCPT TO:<tduszyns@...il.com>
RCPT TO:<jic23@...nel.org>
RCPT TO:<lars@...afoo.de>
RCPT TO:<robh@...nel.org>
RCPT TO:<krzk+dt@...nel.org>
RCPT TO:<conor+dt@...nel.org>
RCPT TO:<linux-iio@...r.kernel.org>
RCPT TO:<devicetree@...r.kernel.org>
RCPT TO:<linux-kernel@...r.kernel.org>
RCPT TO:<sergio@...eznus.es>
From: Sergio Perez <sergio@...eznus.es>
To: Tomasz Duszynski <tduszyns@...il.com>,
         Jonathan Cameron <jic23@...nel.org>,
         Lars-Peter Clausen <lars@...afoo.de>,
         Rob Herring <robh@...nel.org>,
         Krzysztof Kozlowski <krzk+dt@...nel.org>,
         Conor Dooley <conor+dt@...nel.org>,
         linux-iio@...r.kernel.org,
         devicetree@...r.kernel.org,
         linux-kernel@...r.kernel.org
Cc: Sergio Perez <sergio@...eznus.es>
Subject: [PATCH v3 2/2] iio: light: bh1750: Add hardware reset support 
via GPIO
Date: Wed, 19 Mar 2025 17:11:17 +0100
Message-ID: <20250319161117.1780-2-sergio@...eznus.es>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20250319161117.1780-1-sergio@...eznus.es>
References: <20250319161117.1780-1-sergio@...eznus.es>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Result: 250

>> (or just use my git_send_email for last two)
>> (or just use b4 for last four)
>>
>> The burden of reading the contributing guides is on you. We documented
>> all this on purpose, so we will not have to repeat this on every email.
>>
>>
>> [1]
>> https://github.com/search?q=repo%3Akrzk%2Ftools%20git_send_email&type=code
>>
>> Best regards,
>> Krzysztof
>
> Best regards,
> Krzysztof