linux-kernel - Re: [PATCH v4 1/2] wifi: mwifiex: Fix premature release of RF calibration data.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250319162842.GA46894@francesco-nb>
Date: Wed, 19 Mar 2025 17:28:42 +0100
From: Francesco Dolcini <francesco@...cini.it>
To: Jeff Chen <jeff.chen_1@....com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	briannorris@...omium.org, johannes@...solutions.net,
	francesco@...cini.it, tsung-hsien.hsieh@....com,
	s.hauer@...gutronix.de
Subject: Re: [PATCH v4 1/2] wifi: mwifiex: Fix premature release of RF
 calibration data.

Hello Jeff,

On Tue, Mar 18, 2025 at 01:07:38PM +0800, Jeff Chen wrote:
> This patch resolves an issue where RF calibration data was being
> released before the download process. Without this fix, the
> external calibration data file would not be downloaded
> at all.
> 
> Fixes: d39fbc88956e ("mwifiex: remove cfg_data construction")
> Signed-off-by: Jeff Chen <jeff.chen_1@....com>

The code looks ok to me, however I do not understand the commit you
selected as fixes tag.

>From what I understand releasing the data before using it was done since
the initial commit 388ec385d5ce ("mwifiex: add calibration data download
feature"). What am I missing?

Francesco