linux-kernel - Re: [PATCH v2] keys: Fix UAF in key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgqidLD38wYUw-5Y6ztFdAvkX3P+Gv2=K+rpkFBG-bf7g@mail.gmail.com>
Date: Wed, 19 Mar 2025 11:11:56 -0700
From: Linus Torvalds <torvalds@...uxfoundation.org>
To: Oleg Nesterov <oleg@...hat.com>
Cc: David Howells <dhowells@...hat.com>, Jarkko Sakkinen <jarkko@...nel.org>, Kees Cook <kees@...nel.org>, 
	Greg KH <gregkh@...uxfoundation.org>, Josh Drake <josh@...phoslabs.com>, 
	Suraj Sonawane <surajsonawane0215@...il.com>, keyrings@...r.kernel.org, 
	linux-security-module@...r.kernel.org, security@...nel.org, 
	stable@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] keys: Fix UAF in key_put()

On Wed, 19 Mar 2025 at 09:31, Oleg Nesterov <oleg@...hat.com> wrote:
>
> Can't resist, smp_mb__before_atomic() should equally work,
> but this doesn't really matter, please forget.

We really should have "test_bit_acquire()" and "set_bit_release()".

Well, we do have the test_bit_acquire().

We just don't have the set_bit side, because we only have the bit
clearing version (and it's called "clear_bit_unlock()" for historical
reasons).

Annoying.

             Linus