linux-kernel - Re: [PATCH v2] keys: Fix UAF in key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2883313.1742410054@warthog.procyon.org.uk>
Date: Wed, 19 Mar 2025 18:47:34 +0000
From: David Howells <dhowells@...hat.com>
To: Linus Torvalds <torvalds@...uxfoundation.org>
Cc: dhowells@...hat.com, Oleg Nesterov <oleg@...hat.com>,
    Jarkko Sakkinen <jarkko@...nel.org>, Kees Cook <kees@...nel.org>,
    Greg KH <gregkh@...uxfoundation.org>,
    Josh Drake <josh@...phoslabs.com>,
    Suraj Sonawane <surajsonawane0215@...il.com>,
    keyrings@...r.kernel.org, linux-security-module@...r.kernel.org,
    security@...nel.org, stable@...r.kernel.org,
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] keys: Fix UAF in key_put()

Linus Torvalds <torvalds@...uxfoundation.org> wrote:

> We really should have "test_bit_acquire()" and "set_bit_release()".

I considered using test_bit_acquire() but, as you say, there's no
set_bit_release() as yet.  I could switch things to initialise the flag to set
on key creation and clear the flag instead.

David