linux-kernel - Re: [PATCH] HID: appletb-kbd: Replace msecs_to_jiffies with secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9c3eca1-5dc9-46e1-a356-87643434cee0@kernel.org>
Date: Wed, 19 Mar 2025 08:26:48 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: xie.ludan@....com.cn, bentiss@...nel.org
Cc: jikos@...nel.org, linux-input@...r.kernel.org,
 linux-kernel@...r.kernel.org, xu.xin16@....com.cn, yang.yang29@....com.cn,
 jiang.peng9@....com.cn
Subject: Re: [PATCH] HID: appletb-kbd: Replace msecs_to_jiffies with
 secs_to_jiffies for timer settings

On 19/03/2025 03:12, xie.ludan@....com.cn wrote:
> From: Peng Jiang <jiang.peng9@....com.cn>
> 
> The variables `appletb_tb_idle_timeout` and `appletb_tb_dim_timeout`
> are already defined in seconds, so using `secs_to_jiffies` directly
> makes the code more readable and consistent with the units used.
> 
> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
> the following Coccinelle rules:

Why do you need to paste here contentx of existing cocci script? It's
already mainlined, no?

> 
> @depends on patch@
> expression E;
> @@
> 
> -msecs_to_jiffies
> +secs_to_jiffies
> (E
> - * \( 1000 \| MSEC_PER_SEC \)
> )
> 
> Signed-off-by: Peng Jiang <jiang.peng9@....com.cn>
> Signed-off-by: XieLudan <xie.ludan@....com.cn>
Same comment as before. Did you respond to previous feedbacks? No.

Best regards,
Krzysztof