linux-kernel - Re: [PATCH] HID: appletb-kbd: Replace msecs_to_jiffies with secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250319160139161M5v1ERrZqTRfyixTQV7bU@zte.com.cn>
Date: Wed, 19 Mar 2025 16:01:39 +0800 (CST)
From: <jiang.peng9@....com.cn>
To: <krzk@...nel.org>
Cc: <xie.ludan@....com.cn>, <bentiss@...nel.org>, <jikos@...nel.org>,
        <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <xu.xin16@....com.cn>, <yang.yang29@....com.cn>
Subject: Re: [PATCH] HID: appletb-kbd: Replace msecs_to_jiffies with secs_to_jiffies for timer settings

> > From: Peng Jiang <jiang.peng9@....com.cn>
> >
> > The variables `appletb_tb_idle_timeout` and `appletb_tb_dim_timeout`
> > are already defined in seconds, so using `secs_to_jiffies` directly
> > makes the code more readable and consistent with the units used.
> >
> > This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
> > the following Coccinelle rules:
>
> Why do you need to paste here contentx of existing cocci script? It's
> already mainlined, no?
>
> >
> > @depends on patch@
> > expression E;
> > @@
> >
> > -msecs_to_jiffies
> > +secs_to_jiffies
> > (E
> > - * \( 1000 \| MSEC_PER_SEC \)
> > )
> >
I intended to refer to the source of the modifications. Therefore, removing the Coccinelle script is appropriate.

Thank you for your feedback!

Best regards,
Peng Jiang