linux-kernel - Re: [PATCH] sched/topology: Fix sched_is_eas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30adb3ee-60d2-499f-94d5-0880e83c4403@arm.com>
Date: Wed, 19 Mar 2025 11:18:56 +0000
From: Christian Loehle <christian.loehle@....com>
To: Vincent Guittot <vincent.guittot@...aro.org>
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
 Juri Lelli <juri.lelli@...hat.com>,
 Dietmar Eggemann <dietmar.eggemann@....com>,
 Steven Rostedt <rostedt@...dmis.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched/topology: Fix sched_is_eas_possible() prints

On 3/19/25 11:07, Vincent Guittot wrote:
> On Wed, 19 Mar 2025 at 11:59, Christian Loehle <christian.loehle@....com> wrote:
>>
>> Add the missing newline on two failure prints to ensure EAS abort
>> reasons don't go missing.
> 
> Would be good to have a Fixes tag
> 
> Reviewed-by: Vincent Guittot <vincent.guittot@...aro.org>

You're right, thanks.
It's
fa50e2b452c6 ("sched/topology: Condition EAS enablement on FIE support")
8f833c82cdab ("sched/topology: Change behaviour of the 'sched_energy_aware' sysctl, based on the platform")
respectively, so I'll split this to make backporting easier and carry
your R-b in both if you don't mind.