linux-kernel - Re: [PATCH] sched/topology: Fix sched_is_eas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtCEEqjOw+5k9d9a-5P_iu5doNT65EiMmhdhXytDnXdmMw@mail.gmail.com>
Date: Wed, 19 Mar 2025 12:07:14 +0100
From: Vincent Guittot <vincent.guittot@...aro.org>
To: Christian Loehle <christian.loehle@....com>
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, 
	Juri Lelli <juri.lelli@...hat.com>, Dietmar Eggemann <dietmar.eggemann@....com>, 
	Steven Rostedt <rostedt@...dmis.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched/topology: Fix sched_is_eas_possible() prints

On Wed, 19 Mar 2025 at 11:59, Christian Loehle <christian.loehle@....com> wrote:
>
> Add the missing newline on two failure prints to ensure EAS abort
> reasons don't go missing.

Would be good to have a Fixes tag

Reviewed-by: Vincent Guittot <vincent.guittot@...aro.org>

>
> Signed-off-by: Christian Loehle <christian.loehle@....com>
> ---
>  kernel/sched/topology.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index c49aea8c1025..18e804b416f5 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -245,7 +245,7 @@ static bool sched_is_eas_possible(const struct cpumask *cpu_mask)
>
>         if (!arch_scale_freq_invariant()) {
>                 if (sched_debug()) {
> -                       pr_info("rd %*pbl: Checking EAS: frequency-invariant load tracking not yet supported",
> +                       pr_info("rd %*pbl: Checking EAS: frequency-invariant load tracking not yet supported\n",
>                                 cpumask_pr_args(cpu_mask));
>                 }
>                 return false;
> @@ -256,7 +256,7 @@ static bool sched_is_eas_possible(const struct cpumask *cpu_mask)
>                 policy = cpufreq_cpu_get(i);
>                 if (!policy) {
>                         if (sched_debug()) {
> -                               pr_info("rd %*pbl: Checking EAS, cpufreq policy not set for CPU: %d",
> +                               pr_info("rd %*pbl: Checking EAS, cpufreq policy not set for CPU: %d\n",
>                                         cpumask_pr_args(cpu_mask), i);
>                         }
>                         return false;
> --
> 2.34.1