| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202503202311.5PZH0XKm-lkp@intel.com>
Date: Fri, 21 Mar 2025 00:12:50 +0800
From: kernel test robot <lkp@...el.com>
To: Alexis Czezar Torreno <alexisczezar.torreno@...log.com>,
Jean Delvare <jdelvare@...e.com>,
Guenter Roeck <linux@...ck-us.net>,
Jonathan Corbet <corbet@....net>,
Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-hwmon@...r.kernel.org,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-i2c@...r.kernel.org,
Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
Subject: Re: [PATCH 2/2] hwmon: (pmbus/max3440): add support adpm12160
Hi Alexis,
kernel test robot noticed the following build errors:
[auto build test ERROR on c812cc42f92d3d0b17c01b5db9a1dee5793a1491]
url: https://github.com/intel-lab-lkp/linux/commits/Alexis-Czezar-Torreno/hwmon-pmbus-max34440-Fix-support-for-max34451/20250320-115905
base: c812cc42f92d3d0b17c01b5db9a1dee5793a1491
patch link: https://lore.kernel.org/r/20250320-dev_adpm12160-v1-2-8f7b975eac75%40analog.com
patch subject: [PATCH 2/2] hwmon: (pmbus/max3440): add support adpm12160
config: i386-buildonly-randconfig-005-20250320 (https://download.01.org/0day-ci/archive/20250320/202503202311.5PZH0XKm-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250320/202503202311.5PZH0XKm-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503202311.5PZH0XKm-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/hwmon/pmbus/max34440.c: In function 'max34440_read_word_data':
>> drivers/hwmon/pmbus/max34440.c:97:71: error: expected statement before ')' token
97 | data->id != max34451_na6 && data->id != adpm12160))
| ^
drivers/hwmon/pmbus/max34440.c: At top level:
drivers/hwmon/pmbus/max34440.c:483:37: error: expected expression before ',' token
483 | MAX34451_COMMON_INFO,
| ^
drivers/hwmon/pmbus/max34440.c:486:37: error: expected expression before ',' token
486 | MAX34451_COMMON_INFO,
| ^
In file included from include/linux/module.h:22,
from drivers/hwmon/pmbus/max34440.c:11:
drivers/hwmon/pmbus/max34440.c:603:18: error: expected ',' or ';' before 'PMBUS'
603 | MODULE_IMPORT_NS(PMBUS);
| ^~~~~
include/linux/moduleparam.h:26:61: note: in definition of macro '__MODULE_INFO'
26 | = __MODULE_INFO_PREFIX __stringify(tag) "=" info
| ^~~~
include/linux/module.h:299:33: note: in expansion of macro 'MODULE_INFO'
299 | #define MODULE_IMPORT_NS(ns) MODULE_INFO(import_ns, ns)
| ^~~~~~~~~~~
drivers/hwmon/pmbus/max34440.c:603:1: note: in expansion of macro 'MODULE_IMPORT_NS'
603 | MODULE_IMPORT_NS(PMBUS);
| ^~~~~~~~~~~~~~~~
vim +97 drivers/hwmon/pmbus/max34440.c
62
63 static int max34440_read_word_data(struct i2c_client *client, int page,
64 int phase, int reg)
65 {
66 int ret;
67 const struct pmbus_driver_info *info = pmbus_get_driver_info(client);
68 const struct max34440_data *data = to_max34440_data(info);
69
70 switch (reg) {
71 case PMBUS_IOUT_OC_FAULT_LIMIT:
72 if (data->id == max34451_na6 || data->id == adpm12160)
73 ret = pmbus_read_word_data(client, page, phase,
74 PMBUS_IOUT_OC_FAULT_LIMIT);
75 else
76 ret = pmbus_read_word_data(client, page, phase,
77 MAX34440_IOUT_OC_FAULT_LIMIT);
78 break;
79 case PMBUS_IOUT_OC_WARN_LIMIT:
80 if (data->id == max34451_na6 || data->id == adpm12160)
81 ret = pmbus_read_word_data(client, page, phase,
82 PMBUS_IOUT_OC_WARN_LIMIT);
83 else
84 ret = pmbus_read_word_data(client, page, phase,
85 MAX34440_IOUT_OC_WARN_LIMIT);
86 break;
87 case PMBUS_VIRT_READ_VOUT_MIN:
88 ret = pmbus_read_word_data(client, page, phase,
89 MAX34440_MFR_VOUT_MIN);
90 break;
91 case PMBUS_VIRT_READ_VOUT_MAX:
92 ret = pmbus_read_word_data(client, page, phase,
93 MAX34440_MFR_VOUT_PEAK);
94 break;
95 case PMBUS_VIRT_READ_IOUT_AVG:
96 if (data->id != max34446 && data->id != max34451 &&
> 97 data->id != max34451_na6 && data->id != adpm12160))
98 return -ENXIO;
99 ret = pmbus_read_word_data(client, page, phase,
100 MAX34446_MFR_IOUT_AVG);
101 break;
102 case PMBUS_VIRT_READ_IOUT_MAX:
103 ret = pmbus_read_word_data(client, page, phase,
104 MAX34440_MFR_IOUT_PEAK);
105 break;
106 case PMBUS_VIRT_READ_POUT_AVG:
107 if (data->id != max34446)
108 return -ENXIO;
109 ret = pmbus_read_word_data(client, page, phase,
110 MAX34446_MFR_POUT_AVG);
111 break;
112 case PMBUS_VIRT_READ_POUT_MAX:
113 if (data->id != max34446)
114 return -ENXIO;
115 ret = pmbus_read_word_data(client, page, phase,
116 MAX34446_MFR_POUT_PEAK);
117 break;
118 case PMBUS_VIRT_READ_TEMP_AVG:
119 if (data->id != max34446 && data->id != max34460 &&
120 data->id != max34461)
121 return -ENXIO;
122 ret = pmbus_read_word_data(client, page, phase,
123 MAX34446_MFR_TEMPERATURE_AVG);
124 break;
125 case PMBUS_VIRT_READ_TEMP_MAX:
126 ret = pmbus_read_word_data(client, page, phase,
127 MAX34440_MFR_TEMPERATURE_PEAK);
128 break;
129 case PMBUS_VIRT_RESET_POUT_HISTORY:
130 if (data->id != max34446)
131 return -ENXIO;
132 ret = 0;
133 break;
134 case PMBUS_VIRT_RESET_VOUT_HISTORY:
135 case PMBUS_VIRT_RESET_IOUT_HISTORY:
136 case PMBUS_VIRT_RESET_TEMP_HISTORY:
137 ret = 0;
138 break;
139 default:
140 ret = -ENODATA;
141 break;
142 }
143 return ret;
144 }
145
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists