linux-kernel - Re: [PATCH net-next v6 4/7] net: phy: aquantia: add essential functions to aqr105 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <075283ba-ced1-4aa8-b9ec-7bb456d1d82a@lunn.ch>
Date: Thu, 20 Mar 2025 22:20:38 +0100
From: Andrew Lunn <andrew@...n.ch>
To: hfdevel@....net
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	FUJITA Tomonori <fujita.tomonori@...il.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v6 4/7] net: phy: aquantia: add essential
 functions to aqr105 driver

> +static int aqr105_config_speed(struct phy_device *phydev)
> +{

This is used when autoneg is disabled. Generally the name would be
_setup_forced, e.g. genphy_setup_forced(). Sticking to that naming
convention makes is simpler to understand if you know other PHY
drivers.

Once you have changed this, you can add my Reviewed-by:

    Andrew

---
pw-bot: cr