linux-kernel - Re: [PATCH net-next v6 5/7] net: tn40xx: create swnode for mdio and aqr105 phy and add to mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d7a7499-f8cf-4e35-9692-78c9037b35c4@lunn.ch>
Date: Thu, 20 Mar 2025 22:23:57 +0100
From: Andrew Lunn <andrew@...n.ch>
To: hfdevel@....net
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	FUJITA Tomonori <fujita.tomonori@...il.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v6 5/7] net: tn40xx: create swnode for mdio and
 aqr105 phy and add to mdiobus

> +void tn40_swnodes_cleanup(struct tn40_priv *priv)
> +{
> +	/* cleanup of swnodes is only needed for AQR105-based cards */
> +	if (priv->pdev->device == 0x4025) {

Maybe replace this magic number with a #define?

      Andrew