linux-kernel - Re: [PATCH v2 1/1] audit: Mark audit_log_vformat() with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7f860b806603cd8af7740c73db68197@paul-moore.com>
Date: Thu, 20 Mar 2025 18:02:12 -0400
From: Paul Moore <paul@...l-moore.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Casey Schaufler <casey@...aufler-ca.com>, audit@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Eric Paris <eparis@...hat.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v2 1/1] audit: Mark audit_log_vformat() with __printf()  attribute

On Mar 13, 2025 Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> 
> audit_log_vformat() is using printf() type of format, and GCC compiler
> (Debian 14.2.0-17) is not happy about this:
> 
> kernel/audit.c:1978:9: error: function ‘audit_log_vformat’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
> kernel/audit.c:1987:17: error: function ‘audit_log_vformat’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
> 
> Fix the compilation errors (`make W=1` when CONFIG_WERROR=y, which is default)
> by adding __printf() attribute.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> v2: added necessary technical information to the commit message (Paul)
> 
>  kernel/audit.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Merged into audit/dev-staging, this will move to audit/dev after the
upcoming merge window.

--
paul-moore.com