linux-kernel - Re: [PATCH v2 1/1] audit: Mark audit_log_vformat() with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9wx60LEpqN4BF5W@smile.fi.intel.com>
Date: Thu, 20 Mar 2025 17:19:07 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Paul Moore <paul@...l-moore.com>,
	Casey Schaufler <casey@...aufler-ca.com>, audit@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: Eric Paris <eparis@...hat.com>
Subject: Re: [PATCH v2 1/1] audit: Mark audit_log_vformat() with __printf()
 attribute

On Thu, Mar 13, 2025 at 10:52:39AM +0200, Andy Shevchenko wrote:
> audit_log_vformat() is using printf() type of format, and GCC compiler
> (Debian 14.2.0-17) is not happy about this:
> 
> kernel/audit.c:1978:9: error: function ‘audit_log_vformat’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
> kernel/audit.c:1987:17: error: function ‘audit_log_vformat’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
> 
> Fix the compilation errors (`make W=1` when CONFIG_WERROR=y, which is default)
> by adding __printf() attribute.

Any comments on this? Can it be applied?

-- 
With Best Regards,
Andy Shevchenko