linux-kernel - Re: (subset) [RFC PATCH v5 0/5] introduce io_uring_cmd_import_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <457194e1-409d-455c-a863-4877934006a0@gmail.com>
Date: Thu, 20 Mar 2025 11:53:33 +0000
From: Pavel Begunkov <asml.silence@...il.com>
To: Jens Axboe <axboe@...nel.dk>, Josef Bacik <josef@...icpanda.com>,
 David Sterba <dsterba@...e.com>, Sidong Yang <sidong.yang@...iosa.ai>
Cc: linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
 io-uring@...r.kernel.org
Subject: Re: (subset) [RFC PATCH v5 0/5] introduce
 io_uring_cmd_import_fixed_vec

On 3/19/25 15:27, Jens Axboe wrote:
> On 3/19/25 9:26 AM, Jens Axboe wrote:
>>
>> On Wed, 19 Mar 2025 06:12:46 +0000, Sidong Yang wrote:
>>> This patche series introduce io_uring_cmd_import_vec. With this function,
>>> Multiple fixed buffer could be used in uring cmd. It's vectored version
>>> for io_uring_cmd_import_fixed(). Also this patch series includes a usage
>>> for new api for encoded read/write in btrfs by using uring cmd.
>>>
>>> There was approximately 10 percent of performance improvements through benchmark.
>>> The benchmark code is in
>>> https://github.com/SidongYang/btrfs-encoded-io-test/blob/main/main.c
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/5] io_uring: rename the data cmd cache
>>        commit: 575e7b0629d4bd485517c40ff20676180476f5f9
>> [2/5] io_uring/cmd: don't expose entire cmd async data
>>        commit: 5f14404bfa245a156915ee44c827edc56655b067
>> [3/5] io_uring/cmd: add iovec cache for commands
>>        commit: fe549edab6c3b7995b58450e31232566b383a249
>> [4/5] io_uring/cmd: introduce io_uring_cmd_import_fixed_vec
>>        commit: b24cb04c1e072ecd859a98b2e4258ca8fe8d2d4d
> 
> 1-4 look pretty straight forward to me - I'll be happy to queue the
> btrfs one as well if the btrfs people are happy with it, just didn't
> want to assume anything here.

fwiw, finally got time to wire a hacky test with a separate cmd,
works fine, but I'll need to setup btrfs to test the last patch.

-- 
Pavel Begunkov