linux-kernel - Re: [PATCH 2/3] net: mana: Implement set_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb6b544f-f683-4307-8adf-82d37540c556@lunn.ch>
Date: Thu, 20 Mar 2025 14:43:34 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
	decui@...rosoft.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	longli@...rosoft.com, kotaranov@...rosoft.com, horms@...nel.org,
	brett.creeley@....com, surenb@...gle.com,
	schakrabarti@...ux.microsoft.com, kent.overstreet@...ux.dev,
	shradhagupta@...ux.microsoft.com, erick.archer@...look.com,
	rosenp@...il.com, linux-hyperv@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-rdma@...r.kernel.org
Subject: Re: [PATCH 2/3] net: mana: Implement set_link_ksettings in ethtool
 for speed

On Thu, Mar 20, 2025 at 05:22:20AM -0700, Erni Sri Satya Vennela wrote:
> Add support for ethtool_set_link_ksettings for mana.
> Set speed information of the port using ethtool. This
> feature is not supported by all hardware.
> 
> Before the change:
> $ethtool -s enP30832s1 speed 100
> >netlink error: Operation not supported
> $ethtool enP30832s1
> >Settings for enP30832s1:
>         Supported ports: [  ]
>         Supported link modes:   Not reported

Since there are no link modes, what does this speed actually mean?

> After the change:
> $ethtool -s enP30832s1 speed 100

Is 

$ethtool -s enP30832s1 speed 42

permitted? 

or

$ethtool -s enP30832s1 speed -1

	Andrew