linux-kernel - RE: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: add lt3074

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <PH0PR03MB6938087B8F2EDB9899DD0F1D8EDB2@PH0PR03MB6938.namprd03.prod.outlook.com>
Date: Fri, 21 Mar 2025 16:53:49 +0000
From: "Encarnacion, Cedric justine" <Cedricjustine.Encarnacion@...log.com>
To: Guenter Roeck <linux@...ck-us.net>, Krzysztof Kozlowski <krzk@...nel.org>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Jean Delvare <jdelvare@...e.com>,
        Jonathan Corbet <corbet@....net>,
        Delphine CC Chiu
	<Delphine_CC_Chiu@...ynn.com>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-hwmon@...r.kernel.org"
	<linux-hwmon@...r.kernel.org>,
        "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>,
        "linux-i2c@...r.kernel.org"
	<linux-i2c@...r.kernel.org>
Subject: RE: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: add lt3074

> -----Original Message-----
> From: Encarnacion, Cedric justine
> Sent: Wednesday, March 19, 2025 12:10 PM
> To: Guenter Roeck <linux@...ck-us.net>; Krzysztof Kozlowski <krzk@...nel.org>
> Cc: Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>;
> Conor Dooley <conor+dt@...nel.org>; Jean Delvare <jdelvare@...e.com>;
> Jonathan Corbet <corbet@....net>; Delphine CC Chiu
> <Delphine_CC_Chiu@...ynn.com>; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-hwmon@...r.kernel.org; linux-
> doc@...r.kernel.org; linux-i2c@...r.kernel.org
> Subject: RE: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: add lt3074
> 
> > -----Original Message-----
> > From: Guenter Roeck <groeck7@...il.com> On Behalf Of Guenter Roeck
> > Sent: Tuesday, March 18, 2025 11:17 PM
> > To: Encarnacion, Cedric justine
> > <Cedricjustine.Encarnacion@...log.com>;
> > Krzysztof Kozlowski <krzk@...nel.org>
> > Cc: Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> > <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Jean Delvare
> > <jdelvare@...e.com>; Jonathan Corbet <corbet@....net>; Delphine CC
> > Chiu <Delphine_CC_Chiu@...ynn.com>; devicetree@...r.kernel.org; linux-
> > kernel@...r.kernel.org; linux-hwmon@...r.kernel.org; linux-
> > doc@...r.kernel.org; linux-i2c@...r.kernel.org
> > Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: add lt3074
> >
> > [External]
> >
> > On 3/18/25 03:03, Encarnacion, Cedric justine wrote:
> > >> -----Original Message-----
> > >> From: Guenter Roeck <groeck7@...il.com> On Behalf Of Guenter Roeck
> > >> Sent: Friday, February 28, 2025 12:33 AM
> > >> To: Krzysztof Kozlowski <krzk@...nel.org>
> > >> Cc: Rob Herring <robh@...nel.org>; Encarnacion, Cedric justine
> > >> <Cedricjustine.Encarnacion@...log.com>; Krzysztof Kozlowski
> > >> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Jean
> > >> Delvare <jdelvare@...e.com>; Jonathan Corbet <corbet@....net>;
> > >> Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>;
> > >> devicetree@...r.kernel.org; linux- kernel@...r.kernel.org;
> > >> linux-hwmon@...r.kernel.org; linux- doc@...r.kernel.org;
> > >> linux-i2c@...r.kernel.org
> > >> Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: add lt3074
> > >>
> > >> diff --git a/drivers/hwmon/pmbus/pmbus.h
> > >> b/drivers/hwmon/pmbus/pmbus.h index ddb19c9726d6..289767e5d599
> > >> 100644
> > >> --- a/drivers/hwmon/pmbus/pmbus.h
> > >> +++ b/drivers/hwmon/pmbus/pmbus.h
> > >> @@ -512,7 +512,6 @@ int pmbus_regulator_init_cb(struct
> > >> regulator_dev
> > *rdev,
> > >>   	{							\
> > >>   		.name = (_name),				\
> > >>   		.of_match = of_match_ptr(_name),		\
> > >> -		.regulators_node = of_match_ptr("regulators"),	\
> > >>   		.ops = &pmbus_regulator_ops,			\
> > >>   		.type = REGULATOR_VOLTAGE,			\
> > >>   		.owner = THIS_MODULE,				\
> > >>
> > >> Maybe someone can check if that works.
> > >>
> > >> Thanks,
> > >> Guenter
> > >
> > > I'd like to follow up on this one. As of this writing, my
> > > understanding is that the dt-binding should not expect regulators
> > > subnodes for simple devices like this. There is already a similar
> > > binding as mentioned in this thread particularly
> > > "dt-bindings/regulator/infineon,ir38060". I think a binding without
> > > the subnodes should still work with or without the change above.
> >
> > Interesting. I am not sure if it really works, though. I looked into
> > the regulator code, and I don't immediately see the code path it would
> > take.
> >
> > > With this, I'd like to know what the specific next steps are to
> > > continue this patch series.
> >
> > Can you try on hardware using a devicetree file which doesn't have the
> > regulators node ? If the current code works, just submit an updated
> > (simplified) .yaml file and we should be good. If not, I have an
> > untested patch series introducing another macro which doesn't set the
> > regulators node.
> 
> Okay. I'll test this and get back to you.

The "simplified" dt file (without the regulators node) does not work with
the current regulator_desc macro. I have also tried simply removing the
regulators_node setting from the regulator_desc macro, and it does not
work too. of_match looks for a certain regulator name in dt, and it seems
like it must handle NULL cases as well as suggested previously. I would
appreciate if this would be also verified on other ends. For now, I think I'll
wait for another macro to be introduced in pmbus to support this kind of
bindings.

Best regards,
Cedric