linux-kernel - Re: [PATCH net-next] net: openvswitch: fix kernel-doc warnings in internal headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1FAE19BE-E1F9-4836-9AF5-5EFB7FD291AD@redhat.com>
Date: Fri, 21 Mar 2025 12:00:51 +0100
From: Eelco Chaudron <echaudro@...hat.com>
To: Ilya Maximets <i.maximets@....org>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 dev@...nvswitch.org, linux-kernel@...r.kernel.org,
 Pravin B Shelar <pshelar@....org>, Aaron Conole <aconole@...hat.com>
Subject: Re: [PATCH net-next] net: openvswitch: fix kernel-doc warnings in
 internal headers

On 20 Mar 2025, at 23:42, Ilya Maximets wrote:

> Some field descriptions were missing, some were not very accurate.
> Not touching the uAPI header or .c files for now.
>
> Formatting of those comments isn't great in general, but at least
> they are not missing anything now.
>
> Before:
>   $ ./scripts/kernel-doc -none -Wall net/openvswitch/*.h 2>&1 | wc -l
>   16
>
> After:
>   $ ./scripts/kernel-doc -none -Wall net/openvswitch/*.h 2>&1 | wc -l
>   0
>
> Signed-off-by: Ilya Maximets <i.maximets@....org>

Thanks for taking the time to fix this. The changes look good to me.

Acked-by: Eelco Chaudron <echaudro@...hat.com>