linux-kernel - Re: [PATCH] docs: vfs: Update struct file_system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z-AZiYwkE9PsST90@casper.infradead.org>
Date: Sun, 23 Mar 2025 14:24:09 +0000
From: Matthew Wilcox <willy@...radead.org>
To: I Hsin Cheng <richard120310@...il.com>
Cc: corbet@....net, linux-fsdevel@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] docs: vfs: Update struct file_system_type

On Sun, Mar 23, 2025 at 11:47:25AM +0800, I Hsin Cheng wrote:
> The structure definition now in the kernel adds macros defining the
> value of "fs_flags", and the value "FS_NO_DCACHE" no longer exists,
> update it to an existing flag value.

What value does it add to duplicate these flag definitions in the
documentation?  I would not do this.

> @@ -140,7 +148,7 @@ members are defined:
>  	"msdos" and so on
>  
>  ``fs_flags``
> -	various flags (i.e. FS_REQUIRES_DEV, FS_NO_DCACHE, etc.)
> +	various flags (i.e. FS_REQUIRES_DEV, FS_BINARY_MOUNTDATA, etc.)

This should be "eg.", not "i.e."