linux-kernel - Re: [PATCH] docs: vfs: Update struct file_system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z-Vgrx0XSDASGnpg@vaxr-BM6660-BM6360>
Date: Thu, 27 Mar 2025 22:29:03 +0800
From: I Hsin Cheng <richard120310@...il.com>
To: Matthew Wilcox <willy@...radead.org>
Cc: corbet@....net, linux-fsdevel@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] docs: vfs: Update struct file_system_type

On Sun, Mar 23, 2025 at 02:24:09PM +0000, Matthew Wilcox wrote:
> On Sun, Mar 23, 2025 at 11:47:25AM +0800, I Hsin Cheng wrote:
> > The structure definition now in the kernel adds macros defining the
> > value of "fs_flags", and the value "FS_NO_DCACHE" no longer exists,
> > update it to an existing flag value.
> 
> What value does it add to duplicate these flag definitions in the
> documentation?  I would not do this.
> 
> > @@ -140,7 +148,7 @@ members are defined:
> >  	"msdos" and so on
> >  
> >  ``fs_flags``
> > -	various flags (i.e. FS_REQUIRES_DEV, FS_NO_DCACHE, etc.)
> > +	various flags (i.e. FS_REQUIRES_DEV, FS_BINARY_MOUNTDATA, etc.)
> 
> This should be "eg.", not "i.e."

Hi Matthew,

Thanks for your kindly reply!

> What value does it add to duplicate these flag definitions in the
> documentation?  I would not do this.

I thought the documentation should follow the exact code as in the
kernel, if it only serves as a roughly example, I agree with you then.

> This should be "eg.", not "i.e."

Sure, I'll change it and send v2.

Let me know if anything more is needed to be correct, thanks!

Best regards,
I Hsin Cheng