linux-kernel - Re: [GIT PULL] vfs misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGudoHGJ-z2pYw2ydJcu1LnL=C6Lzozw05QEAgBfj7FEn+4dcA@mail.gmail.com>
Date: Mon, 24 Mar 2025 18:09:27 +0100
From: Mateusz Guzik <mjguzik@...il.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Christian Brauner <brauner@...nel.org>, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] vfs misc

On Mon, Mar 24, 2025 at 5:20 PM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> On Sat, 22 Mar 2025 at 03:13, Christian Brauner <brauner@...nel.org> wrote:
> >
> > Merge conflicts with mainline
> > =============================
> >
> > This contains a minor merge conflict for include/linux/fs.h.
>
> Hmm. My resolution here was to just take the plain VFS_WARN_ON_INODE()
> side, which basically drops commit 37d11cfc6360 ("vfs: sanity check
> the length passed to inode_set_cached_link()") entirely, because that
> one had a "TODO" that implies it's now replaced by the new
> VFS_WARN_ON_INODE() interface.
>
> This is just a note to make sure that if anybody was expecting
> something else, you can now speak up and say "can you please do X".
>
> Or, better yet, send a patch.
>

That TODO thing was a temporary fixup for the release and indeed it is
sorted out in this pull request.

If inode_set_cached_link() looks like this:
static inline void inode_set_cached_link(struct inode *inode, char
*link, int linklen)
{
        VFS_WARN_ON_INODE(strlen(link) != linklen, inode);
        VFS_WARN_ON_INODE(inode->i_opflags & IOP_CACHED_LINK, inode);
        inode->i_link = link;
        inode->i_linklen = linklen;
        inode->i_opflags |= IOP_CACHED_LINK;
}

then you got the right version.

-- 
Mateusz Guzik <mjguzik gmail.com>