linux-kernel - Re: [PATCH] tracing: Fix synth event printk format for str fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250324171202.452e4195@gandalf.local.home>
Date: Mon, 24 Mar 2025 17:12:02 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Douglas Raillard <douglas.raillard@....com>
Cc: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: Fix synth event printk format for str fields

On Mon, 24 Mar 2025 09:40:05 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> So I did take this patch, but thinking about this more, I may remove it.
> 
> The __get_str() doesn't expect a string end. The parser should limit it, as
> the length of the string is saved in the ring buffer. Just like other trace
> events where dynamically size strings only use "%s" and __get_str().
> 
> I think the real fix is to replace the "%.*s" with "%s".

I just tested it out. Yep, it should just be "%s".

-- Steve