linux-kernel - Re: [PATCH v4 10/13] serial: sh-sci: Add support for RZ/T2H SCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-HVD6w6ivYR6pt5@shikoro>
Date: Mon, 24 Mar 2025 22:56:31 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Thierry Bultel <thierry.bultel.yh@...renesas.com>
Cc: "thierry.bultel@...atsea.fr" <thierry.bultel@...atsea.fr>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"geert@...ux-m68k.org" <geert@...ux-m68k.org>,
	Paul Barker <paul.barker.ct@...renesas.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH v4 10/13] serial: sh-sci: Add support for RZ/T2H SCI


> > > +config SERIAL_RZ_SCI
> > 
> > I think this name is too generic. Most RZ-variants so far do not have this
> > SoC. Would 'RZT2H' work or is it too narrow then?
> 
> This is too narrow, because for instance the RZ/N2H , which is very similar, has the same SCI

You know the differences better, what could be a suitable name?

> > >  #define PORT_GENERIC	(-1)
> > 
> > Does userspace need to know this port? Can't we use PORT_GENERIC?
> 
> Userspace unlikely needs it. But unfortunately, the port type needs to
> be checked at a number (5) of places in the driver, so the definition
> is needed.

Yes, true. You just keep consistent with the driver. OK.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)