linux-kernel - RE: [PATCH v4 10/13] serial: sh-sci: Add support for RZ/T2H SCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYCPR01MB114922CBDC2911E2F644BDADC8AA42@TYCPR01MB11492.jpnprd01.prod.outlook.com>
Date: Mon, 24 Mar 2025 12:49:42 +0000
From: Thierry Bultel <thierry.bultel.yh@...renesas.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
CC: "thierry.bultel@...atsea.fr" <thierry.bultel@...atsea.fr>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"geert@...ux-m68k.org" <geert@...ux-m68k.org>, Paul Barker
	<paul.barker.ct@...renesas.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-serial@...r.kernel.org"
	<linux-serial@...r.kernel.org>
Subject: RE: [PATCH v4 10/13] serial: sh-sci: Add support for RZ/T2H SCI

Hi Wolfram,

> -----Original Message-----
> From: Wolfram Sang <wsa+renesas@...g-engineering.com>
> Sent: lundi 24 mars 2025 10:43
> To: Thierry Bultel <thierry.bultel.yh@...renesas.com>
> Cc: thierry.bultel@...atsea.fr; linux-renesas-soc@...r.kernel.org;
> geert@...ux-m68k.org; Paul Barker <paul.barker.ct@...renesas.com>; linux-
> kernel@...r.kernel.org; linux-serial@...r.kernel.org
> Subject: Re: [PATCH v4 10/13] serial: sh-sci: Add support for RZ/T2H SCI
> 
> 
> > +config SERIAL_RZ_SCI
> 
> I think this name is too generic. Most RZ-variants so far do not have this
> SoC. Would 'RZT2H' work or is it too narrow then?

This is too narrow, because for instance the RZ/N2H , which is very similar, has the same SCI

> 
> > +	SCIx_RZT2H_SCI_REGTYPE,
> 
> This name is better.
> 
> >  struct plat_sci_port {
> > -	unsigned int	type;			/* SCI / SCIF / IRDA / HSCIF */
> > +	unsigned int	type;			/* SCI / SCIF / IRDA / HSCIF /
> RZSCI */
> 
> "RZT2" in the comment as well.
> 
> > +/* SH-SCI */
> > +#define PORT_RZSCI	124
> > +
> >  /* Generic type identifier for ports which type is not important to
> userspace. */
> >  #define PORT_GENERIC	(-1)
> 
> Does userspace need to know this port? Can't we use PORT_GENERIC?

Userspace unlikely needs it. But unfortunately, the port type needs to be checked at a number (5) of places in the driver, so the definition is needed.

Thierry