linux-kernel - Re: [PATCH v4 10/13] serial: sh-sci: Add support for RZ/T2H SCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-EpPL3tn54E8KG5@shikoro>
Date: Mon, 24 Mar 2025 10:43:24 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Thierry Bultel <thierry.bultel.yh@...renesas.com>
Cc: thierry.bultel@...atsea.fr, linux-renesas-soc@...r.kernel.org,
	geert@...ux-m68k.org, paul.barker.ct@...renesas.com,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v4 10/13] serial: sh-sci: Add support for RZ/T2H SCI


> +config SERIAL_RZ_SCI

I think this name is too generic. Most RZ-variants so far do not have
this SoC. Would 'RZT2H' work or is it too narrow then?

> +	SCIx_RZT2H_SCI_REGTYPE,

This name is better.

>  struct plat_sci_port {
> -	unsigned int	type;			/* SCI / SCIF / IRDA / HSCIF */
> +	unsigned int	type;			/* SCI / SCIF / IRDA / HSCIF / RZSCI */

"RZT2" in the comment as well.

> +/* SH-SCI */
> +#define PORT_RZSCI	124
> +
>  /* Generic type identifier for ports which type is not important to userspace. */
>  #define PORT_GENERIC	(-1)

Does userspace need to know this port? Can't we use PORT_GENERIC?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)