linux-kernel - Re: [PATCH vfs/for-next 0/3] Move splice_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80835395-d43d-46de-8ed6-2cc5c2268b19@kernel.dk>
Date: Mon, 24 Mar 2025 16:14:06 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Joe Damato <jdamato@...tly.com>, linux-fsdevel@...r.kernel.org
Cc: netdev@...r.kernel.org, brauner@...nel.org, asml.silence@...il.com,
 hch@...radead.org, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 horms@...nel.org, Alexander Viro <viro@...iv.linux.org.uk>,
 "David S. Miller" <davem@...emloft.net>, Jan Kara <jack@...e.cz>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH vfs/for-next 0/3] Move splice_to_socket to net/socket.c

On 3/22/25 2:35 PM, Joe Damato wrote:
> Greetings:
> 
> While reading through the splice and socket code I noticed that some
> splice helpers (like sock_splice_read and sock_splice_eof) live in
> net/socket.c, but splice_to_socket does not.
> 
> I am not sure if there is a reason for this, but it seems like moving
> this code provides some advantages:
>   - Eliminates the #ifdef CONFIG_NET from fs/splice.c
>   - Keeps the socket related splice helpers together in net/socket.c
>     where it seems (IMHO) more logical for them to live

Not sure I think this is a good idea. Always nice to get rid of some
ifdefs, but the code really should be where it's mostly related to, and
the socket splice helpers have very little to do with the networking
code, it's mostly just pure splice code.

-- 
Jens Axboe