linux-kernel - Re: [PATCH] smb/server: use sock_create_kern() in create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250324221225.73511-1-kuniyu@amazon.com>
Date: Mon, 24 Mar 2025 15:11:36 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <chenxiaosong@...nxiaosong.com>
CC: <david.laight.linux@...il.com>, <chenxiaosong@...inos.cn>,
	<linkinjeon@...nel.org>, <linux-cifs@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<senozhatsky@...omium.org>, <sfrench@...ba.org>, <tom@...pey.com>
Subject: Re: [PATCH] smb/server: use sock_create_kern() in create_socket()

From: David Laight <david.laight.linux@...il.com>
Date: Mon, 24 Mar 2025 21:07:47 +0000
> On Mon, 24 Mar 2025 06:51:55 +0000
> chenxiaosong@...nxiaosong.com wrote:
> 
> > From: ChenXiaoSong <chenxiaosong@...inos.cn>
> > 
> > The socket resides in kernel space, so use sock_create_kern()
> > instead of sock_create().
> 
> As in the other patches you need to worry about whether the socket
> holds a reference to the network namespace.

Right, and if you don't see any real issue, I recommend leaving
it as is for now because we have seen many refcount issues for
kernel TCP sockets.

And I totally forgot to respin my series after holiday to clean
up such callers.
https://lore.kernel.org/netdev/20241213092152.14057-1-kuniyu@amazon.com/

I'll repost v4 after the merge window with some modification

  1. be less invasive as suggested by Paolo
  2. use sk_net_refcnt_upgrade()