linux-kernel - Re: [PATCH v8 2/4] rust: rename AlwaysRefCounted to RefCounted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-EKcUppzh-5oTI6@mango>
Date: Mon, 24 Mar 2025 07:32:08 +0000
From: Oliver Mangold <oliver.mangold@...me>
To: Boqun Feng <boqun.feng@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Asahi Lina <lina@...hilina.net>, rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 2/4] rust: rename AlwaysRefCounted to RefCounted

On 250321 0920, Boqun Feng wrote:
> On Thu, Mar 13, 2025 at 07:00:11AM +0000, Oliver Mangold wrote:
> > AlwaysRefCounted will become a marker trait to indicate that it is allowed
> > to obtain an ARef from a `&`, which cannot be allowed for types which are
> > also Ownable.
> >
> 
> This commit log doesn't explain why we need to do this.

Hi Boqun,

what exactly do you have in mind? It mentions that it is to allow types that
are both Ownable and RefCounted. That the next step is to introduce
OwnableRefCounted? That we want to safely convert from ARef to Owned?

> > +
> > +// SAFETY: we currently do not implement `Ownable`, thus it is okay to can obtain an `ARef<Request>`
> 
> s/we/We
> 

Missed that one. Thanks.

Best regards,

Oliver