linux-kernel - RE: [PATCH 2/3] ASoC: codec: wcd938x: Convert to GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8459D61091A8BF9ABD94DA7E88A42@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Mon, 24 Mar 2025 07:33:06 +0000
From: Peng Fan <peng.fan@....com>
To: Steev Klimaszewski <steev@...i.org>, "Peng Fan (OSS)"
	<peng.fan@....nxp.com>
CC: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Linus
 Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>
Subject: RE: [PATCH 2/3] ASoC: codec: wcd938x: Convert to GPIO descriptors

Hi Steev,

> Subject: Re: [PATCH 2/3] ASoC: codec: wcd938x: Convert to GPIO
> descriptors
> 
> Hi Peng Fan,
> 
> On Sun, Mar 23, 2025 at 9:28 PM Peng Fan (OSS)
> <peng.fan@....nxp.com> wrote:
> >
> > From: Peng Fan <peng.fan@....com>
> >
> > of_gpio.h is deprecated, update the driver to use GPIO descriptors.
> >  - Use dev_gpiod_get to get GPIO descriptor.
> >  - Use gpiod_set_value to configure output value.
> >
> > With legacy of_gpio API, the driver set gpio value 0 to assert reset,
> > and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW
> flag
> > in DTS, so set GPIOD_ASIS when get GPIO descriptors, and set value 1
> > means output low, set value 0 means output high with gpiod API.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> >  sound/soc/codecs/wcd938x.c | 13 ++++++-------
> >  1 file changed, 6 insertions(+), 7 deletions(-)
> >
> > diff --git a/sound/soc/codecs/wcd938x.c
> b/sound/soc/codecs/wcd938x.c
> > index
> >
> 1ae498c323912ed799dcc033e7777936d90c9284..c70da29406f36883
> e4926eca40ab
> > 5ba5df02c383 100644
> > --- a/sound/soc/codecs/wcd938x.c
> > +++ b/sound/soc/codecs/wcd938x.c
> > @@ -11,7 +11,6 @@
> >  #include <linux/pm_runtime.h>
> >  #include <linux/component.h>
> >  #include <sound/tlv.h>
> > -#include <linux/of_gpio.h>
> >  #include <linux/of.h>
> >  #include <sound/jack.h>
> >  #include <sound/pcm.h>
> > @@ -171,7 +170,7 @@ struct wcd938x_priv {
> >         int flyback_cur_det_disable;
> >         int ear_rx_path;
> >         int variant;
> > -       int reset_gpio;
> > +       struct gpio_desc *reset_gpio;
> >         struct gpio_desc *us_euro_gpio;
> >         u32 micb1_mv;
> >         u32 micb2_mv;
> > @@ -3251,9 +3250,9 @@ static int
> wcd938x_populate_dt_data(struct wcd938x_priv *wcd938x, struct
> device
> >         struct wcd_mbhc_config *cfg = &wcd938x->mbhc_cfg;
> >         int ret;
> >
> > -       wcd938x->reset_gpio = of_get_named_gpio(dev->of_node,
> "reset-gpios", 0);
> > -       if (wcd938x->reset_gpio < 0)
> > -               return dev_err_probe(dev, wcd938x->reset_gpio,
> > +       wcd938x->reset_gpio = devm_gpiod_get(dev, "reset",
> GPIOD_ASIS);
> > +       if (IS_ERR(wcd938x->reset_gpio))
> > +               return dev_err_probe(dev,
> > + PTR_ERR(wcd938x->reset_gpio),
> >                                      "Failed to get reset gpio\n");
> >
> >         wcd938x->us_euro_gpio = devm_gpiod_get_optional(dev,
> > "us-euro", @@ -3297,10 +3296,10 @@ static int
> > wcd938x_populate_dt_data(struct wcd938x_priv *wcd938x, struct
> device
> >
> >  static int wcd938x_reset(struct wcd938x_priv *wcd938x)  {
> > -       gpio_direction_output(wcd938x->reset_gpio, 0);
> > +       gpiod_set_value(wcd938x->reset_gpio, 1);
> >         /* 20us sleep required after pulling the reset gpio to LOW */
> >         usleep_range(20, 30);
> > -       gpio_set_value(wcd938x->reset_gpio, 1);
> > +       gpiod_set_value(wcd938x->reset_gpio, 0);
> >         /* 20us sleep required after pulling the reset gpio to HIGH */
> >         usleep_range(20, 30);
> >
> >
> > --
> > 2.37.1
> >
> >
> 
> With this patchset applied, the wcd938x codec used in the Thinkpad
> X13s stops working:
> 
> wcd938x_codec audio-codec: soundwire device init timeout
> wcd938x_codec audio-codec: ASoC: error at
> snd_soc_component_probe on
> audio-codec: -110
> snd-sc8280xp sound: ASoC: failed to instantiate card -110 snd-
> sc8280xp sound: probe with driver snd-sc8280xp failed with error -110

Thanks for help testing. But per current in-tree DTS, the reset is using
GPIO_ACTIVE_LOW, so it should work.

I am not sure whether you are using firmware published DTS,
if yes, could you please help check the codec node to dump
the reset-gpios property under /sys/firmware/devicetree/xx ?

Thanks,
Peng.

> 
> -- steev