[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250324-5d1d09fc9e50d2276ba56b6f@orel>
Date: Mon, 24 Mar 2025 09:38:29 +0100
From: Andrew Jones <ajones@...tanamicro.com>
To: Clément Léger <cleger@...osinc.com>
Cc: Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>, Anup Patel <anup@...infault.org>,
Atish Patra <atishp@...shpatra.org>, Shuah Khan <shuah@...nel.org>, Jonathan Corbet <corbet@....net>,
linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
kvm@...r.kernel.org, kvm-riscv@...ts.infradead.org, linux-kselftest@...r.kernel.org,
Samuel Holland <samuel.holland@...ive.com>
Subject: Re: [PATCH v4 02/18] riscv: sbi: add new SBI error mappings
On Mon, Mar 24, 2025 at 09:29:33AM +0100, Clément Léger wrote:
>
>
> On 22/03/2025 13:06, Andrew Jones wrote:
> > On Mon, Mar 17, 2025 at 06:06:08PM +0100, Clément Léger wrote:
> >> A few new errors have been added with SBI V3.0, maps them as close as
> >> possible to errno values.
> >>
> >> Signed-off-by: Clément Léger <cleger@...osinc.com>
> >> ---
> >> arch/riscv/include/asm/sbi.h | 9 +++++++++
> >> 1 file changed, 9 insertions(+)
> >>
> >> diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h
> >> index bb077d0c912f..d11d22717b49 100644
> >> --- a/arch/riscv/include/asm/sbi.h
> >> +++ b/arch/riscv/include/asm/sbi.h
> >> @@ -536,11 +536,20 @@ static inline int sbi_err_map_linux_errno(int err)
> >> case SBI_SUCCESS:
> >> return 0;
> >> case SBI_ERR_DENIED:
> >> + case SBI_ERR_DENIED_LOCKED:
> >> return -EPERM;
> >> case SBI_ERR_INVALID_PARAM:
> >> + case SBI_ERR_INVALID_STATE:
> >> + case SBI_ERR_BAD_RANGE:
> >> return -EINVAL;
> >> case SBI_ERR_INVALID_ADDRESS:
> >> return -EFAULT;
> >> + case SBI_ERR_NO_SHMEM:
> >> + return -ENOMEM;
> >> + case SBI_ERR_TIMEOUT:
> >> + return -ETIME;
> >> + case SBI_ERR_IO:
> >> + return -EIO;
> >> case SBI_ERR_NOT_SUPPORTED:
> >> case SBI_ERR_FAILURE:
> >> default:
> >> --
> >> 2.47.2
> >>
> >
> > I'm not a huge fan sbi_err_map_linux_errno() since the mappings seem a bit
> > arbitrary, but if we're going to do it, then these look pretty good to me.
> > Only other thought I had was E2BIG for bad-range, but nah...
Actually, I just recalled that there is an ERANGE, which would probably be
a better match for bad-range than EINVAL, but I'm not sure it matters much
anyway since this function doesn't promise 1-to-1 mappings.
Thanks,
drew
>
> Yeah I also think some mappings are a bit odd even though I skimmed
> through the whole errno list to find the best possible mappings. I'd be
> happy to find something better though.
>
> Thanks,
>
> Clément
>
> >
> > Reviewed-by: Andrew Jones <ajones@...tanamicro.com>
> >
> > Thanks,
> > drew
>
Powered by blists - more mailing lists