linux-kernel - Re: [PATCH 02/11] mm: Call ctor/dtor for kernel PTEs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <efc72f28-0dcb-4811-a20c-73bcdbdf28fb@arm.com>
Date: Mon, 24 Mar 2025 09:37:56 +0100
From: Kevin Brodsky <kevin.brodsky@....com>
To: linux-mm@...ck.org
Cc: linux-kernel@...r.kernel.org, Albert Ou <aou@...s.berkeley.edu>,
 Andreas Larsson <andreas@...sler.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Catalin Marinas <catalin.marinas@....com>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 "David S. Miller" <davem@...emloft.net>,
 Geert Uytterhoeven <geert@...ux-m68k.org>,
 Linus Walleij <linus.walleij@...aro.org>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Mark Rutland <mark.rutland@....com>, Matthew Wilcox <willy@...radead.org>,
 Michael Ellerman <mpe@...erman.id.au>, "Mike Rapoport (IBM)"
 <rppt@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
 Paul Walmsley <paul.walmsley@...ive.com>,
 Peter Zijlstra <peterz@...radead.org>, Qi Zheng
 <zhengqi.arch@...edance.com>, Ryan Roberts <ryan.roberts@....com>,
 Will Deacon <will@...nel.org>, Yang Shi <yang@...amperecomputing.com>,
 linux-arch@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-csky@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
 linux-openrisc@...r.kernel.org, linux-riscv@...ts.infradead.org,
 linux-s390@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 sparclinux@...r.kernel.org
Subject: Re: [PATCH 02/11] mm: Call ctor/dtor for kernel PTEs

On 17/03/2025 15:16, Kevin Brodsky wrote:
> diff --git a/include/asm-generic/pgalloc.h b/include/asm-generic/pgalloc.h
> index e164ca66f0f6..3c8ec3bfea44 100644
> --- a/include/asm-generic/pgalloc.h
> +++ b/include/asm-generic/pgalloc.h
> @@ -23,6 +23,11 @@ static inline pte_t *__pte_alloc_one_kernel_noprof(struct mm_struct *mm)
>  
>  	if (!ptdesc)
>  		return NULL;
> +	if (!pagetable_pte_ctor(mm, ptdesc)) {

As reported by the CI [1], this can cause trouble on x86 because dtor
calls are missing in pud_free_pmd_page() and pmd_free_pte_page(). Will
fix in the next version.

- Kevin

[1] https://lore.kernel.org/oe-lkp/202503211612.e11bd73f-lkp@intel.com/