linux-kernel - Re: [PATCH v5] rust: transmute: Add methods for FromBytes trait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABm2a9crNdCLnHLZ3pHQ--roaAKtM0FGL-tskyvR6rH97exqwg@mail.gmail.com>
Date: Sun, 23 Mar 2025 23:41:36 -0300
From: Christian <christiansantoslima21@...il.com>
To: Benno Lossin <benno.lossin@...ton.me>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, ~lkcamp/patches@...ts.sr.ht, 
	richard120310@...il.com
Subject: Re: [PATCH v5] rust: transmute: Add methods for FromBytes trait

Hi, Benno.

> Why is this commit message wrapped like this?

Probably my text editor.

> What changed in version 5? Or does "Changes in v4" mean "Changes done to
> v4"?

Changes done to v4. I misinterpreted it? If that's the case, I'll
change in the next patch.

> AFAIU this relies on the endianess of the architecture, I would check
> the endianess in the test and then change the assertion based on that.

I see, good catch!

Thanks,
Christian