linux-kernel - Re: [PATCH v1 1/6] seq_buf: Mark binary printing functions with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeB0+jW--U7seG005aprgxUOiyeb=RoQerhakvB8Y68zQ@mail.gmail.com>
Date: Mon, 24 Mar 2025 18:08:12 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Petr Mladek <pmladek@...e.com>, 
	Christophe JAILLET <christophe.jaillet@...adoo.fr>, Kees Cook <kees@...nel.org>, 
	"Masami Hiramatsu (Google)" <mhiramat@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-hardening@...r.kernel.org, linux-trace-kernel@...r.kernel.org, 
	John Ogness <john.ogness@...utronix.de>, Sergey Senozhatsky <senozhatsky@...omium.org>, 
	Andy Shevchenko <andy@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH v1 1/6] seq_buf: Mark binary printing functions with
 __printf() attribute

On Mon, Mar 24, 2025 at 6:03 PM Steven Rostedt <rostedt@...dmis.org> wrote:
>
> On Thu, 20 Mar 2025 20:04:22 +0200
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
>
> > Binary printing functions are using printf() type of format, and compiler
> > is not happy about them as is:
> >
> > lib/seq_buf.c:162:17: error: function ‘seq_buf_bprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
> >
> > Fix the compilation errors by adding __printf() attribute.
>
> Should also note the removal of "extern"

If it is worth it, why not? The idea is to make it slightly more
consistent with code around (file seems to have both approaches).

-- 
With Best Regards,
Andy Shevchenko