[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z-GGUA-xQZVzdIta@shell.armlinux.org.uk>
Date: Mon, 24 Mar 2025 16:20:32 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Woojung Huh <woojung.huh@...rochip.com>,
Andrew Lunn <andrew+netdev@...n.ch>,
Thangaraj Samynathan <Thangaraj.S@...rochip.com>,
Rengarajan Sundararajan <Rengarajan.S@...rochip.com>,
kernel@...gutronix.de, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com,
Phil Elwell <phil@...pberrypi.org>,
Maxime Chevallier <maxime.chevallier@...tlin.com>,
Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next v5 6/6] net: usb: lan78xx: remove unused struct
members
On Wed, Mar 19, 2025 at 09:49:52AM +0100, Oleksij Rempel wrote:
> Remove unused members from struct lan78xx_net, including:
>
> driver_priv
> suspend_count
> link_on
> mdix_ctrl
> interface
> fc_autoneg
> fc_request_control
>
> These fields are no longer used in the driver and can be safely removed
> as part of a cleanup.
Shouldn't these members be removed in the patches that removed their
users? For example, I think "interface" becomes unused in patch 2.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists