linux-kernel - Re: [RFC PATCH V3 31/43] rv64ilp32_abi: maple_tree: Use BITS_PER_LONG instead of CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4gph4xikdbg6loy2id72uyxgldsldecc7gquhymusl3vreiw3a@ephk5ahhrdw7>
Date: Tue, 25 Mar 2025 15:09:37 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: guoren@...nel.org
Cc: arnd@...db.de, gregkh@...uxfoundation.org, torvalds@...ux-foundation.org,
        paul.walmsley@...ive.com, palmer@...belt.com, anup@...infault.org,
        atishp@...shpatra.org, oleg@...hat.com, kees@...nel.org,
        tglx@...utronix.de, will@...nel.org, mark.rutland@....com,
        brauner@...nel.org, akpm@...ux-foundation.org, rostedt@...dmis.org,
        edumazet@...gle.com, unicorn_wang@...look.com, inochiama@...look.com,
        gaohan@...as.ac.cn, shihua@...as.ac.cn, jiawei@...as.ac.cn,
        wuwei2016@...as.ac.cn, drew@...7.com,
        prabhakar.mahadev-lad.rj@...renesas.com, ctsai390@...estech.com,
        wefu@...hat.com, kuba@...nel.org, pabeni@...hat.com,
        josef@...icpanda.com, dsterba@...e.com, mingo@...hat.com,
        peterz@...radead.org, boqun.feng@...il.com, xiao.w.wang@...el.com,
        qingfang.deng@...lower.com.cn, leobras@...hat.com, jszhang@...nel.org,
        conor.dooley@...rochip.com, samuel.holland@...ive.com,
        yongxuan.wang@...ive.com, luxu.kernel@...edance.com, david@...hat.com,
        ruanjinjie@...wei.com, cuiyunhui@...edance.com,
        wangkefeng.wang@...wei.com, qiaozhe@...as.ac.cn, ardb@...nel.org,
        ast@...nel.org, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org, kvm@...r.kernel.org,
        kvm-riscv@...ts.infradead.org, linux-mm@...ck.org,
        linux-crypto@...r.kernel.org, bpf@...r.kernel.org,
        linux-input@...r.kernel.org, linux-perf-users@...r.kernel.org,
        linux-serial@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-arch@...r.kernel.org, maple-tree@...ts.infradead.org,
        linux-trace-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-atm-general@...ts.sourceforge.net, linux-btrfs@...r.kernel.org,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        linux-nfs@...r.kernel.org, linux-sctp@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [RFC PATCH V3 31/43] rv64ilp32_abi: maple_tree: Use
 BITS_PER_LONG instead of CONFIG_64BIT

* guoren@...nel.org <guoren@...nel.org> [250325 08:24]:
> From: "Guo Ren (Alibaba DAMO Academy)" <guoren@...nel.org>
> 
> The Maple tree algorithm uses ulong type for each element. The
> number of slots is based on BITS_PER_LONG for RV64ILP32 ABI, so
> use BITS_PER_LONG instead of CONFIG_64BIT.
> 
> Signed-off-by: Guo Ren (Alibaba DAMO Academy) <guoren@...nel.org>
> ---
>  include/linux/maple_tree.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h
> index cbbcd18d4186..ff6265b6468b 100644
> --- a/include/linux/maple_tree.h
> +++ b/include/linux/maple_tree.h
> @@ -24,7 +24,7 @@
>   *
>   * Nodes in the tree point to their parent unless bit 0 is set.
>   */
> -#if defined(CONFIG_64BIT) || defined(BUILD_VDSO32_64)
> +#if (BITS_PER_LONG == 64) || defined(BUILD_VDSO32_64)

This will break my userspace testing, if you do not update the testing as
well.  This can be found in tools/testing/radix-tree.  Please also look
at the Makefile as well since it will generate a build flag for the
userspace.

This raises other concerns as the code is found with a grep command, so
I'm not sure why it was missed and if anything else is missed?

If you consider this email to be the (unasked) question about what to do
here, then please CC me, the maintainer of the files including the one
you are updating here.

Thank you,
Liam