linux-kernel - Re: [PATCH v10 10/13] drm/atomic-helper: Refactor crtc & encoder-bridge op loops into separate functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d42cfd782bb194754b20ef198f984cbc30a2b029.camel@siemens.com>
Date: Tue, 25 Mar 2025 19:11:17 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "laurent.pinchart@...asonboard.com" <laurent.pinchart@...asonboard.com>,
	"andrzej.hajda@...el.com" <andrzej.hajda@...el.com>,
	"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
	"dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>,
	"tomi.valkeinen@...asonboard.com" <tomi.valkeinen@...asonboard.com>,
	"tzimmermann@...e.de" <tzimmermann@...e.de>, "simona@...ll.ch"
	<simona@...ll.ch>, "rfoss@...nel.org" <rfoss@...nel.org>, "airlied@...il.com"
	<airlied@...il.com>, "aradhya.bhatia@...ux.dev" <aradhya.bhatia@...ux.dev>,
	"jonas@...boo.se" <jonas@...boo.se>, "jernej.skrabec@...il.com"
	<jernej.skrabec@...il.com>, "mripard@...nel.org" <mripard@...nel.org>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>
CC: "j-choudhary@...com" <j-choudhary@...com>, "u-kumar1@...com"
	<u-kumar1@...com>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "devarsht@...com" <devarsht@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "nm@...com"
	<nm@...com>, "vigneshr@...com" <vigneshr@...com>, "praneeth@...com"
	<praneeth@...com>
Subject: Re: [PATCH v10 10/13] drm/atomic-helper: Refactor crtc &
 encoder-bridge op loops into separate functions

On Wed, 2025-02-26 at 21:27 +0530, Aradhya Bhatia wrote:
> From: Aradhya Bhatia <a-bhatia1@...com>
> 
> The way any singular display pipeline, in need of a modeset, gets
> enabled is as follows -
> 
> 	crtc enable
> 	(all) bridge pre-enable
> 	encoder enable
> 	(all) bridge enable
> 
> - and the disable sequence is exactly the reverse of this.
> 
> The crtc operations occur by looping over the old and new crtc states,
> while the encoder and bridge operations occur together, by looping over
> the connector states of the display pipelines.
> 
> Refactor these operations - crtc enable/disable, and encoder & bridge
> (pre/post) enable/disable - into separate functions each, to make way
> for the re-ordering of the enable/disable sequences.
> 
> This patch doesn't alter the sequence of crtc/encoder/bridge operations
> in any way, but helps to cleanly pave the way for the next two patches,
> by maintaining logical bisectability.
> 
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> Tested-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> Signed-off-by: Aradhya Bhatia <a-bhatia1@...com>
> Signed-off-by: Aradhya Bhatia <aradhya.bhatia@...ux.dev>

Tested with AM62 OLDI series [1] on AM625 with single channel AUO 800x480
LVDS panel. No issues with the patch!

Tested-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>

[1] Link: https://lore.kernel.org/all/20250226181300.756610-1-aradhya.bhatia@linux.dev/

> ---
>  drivers/gpu/drm/drm_atomic_helper.c | 69 ++++++++++++++++++++---------
>  1 file changed, 49 insertions(+), 20 deletions(-)

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com