linux-kernel - Re: [PATCH v6 1/1] tracing: Show last module text symbols in the stacktrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250325154955.5ed4fa33@gandalf.local.home>
Date: Tue, 25 Mar 2025 15:49:55 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/1] tracing: Show last module text symbols in the
 stacktrace

On Mon, 24 Mar 2025 23:34:52 +0900
"Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:

> From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> 
> Since the previous boot trace buffer can include module text address in
> the stacktrace. As same as the kernel text address, convert the module
> text address using the module address information.
> 
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202503112205.joXgt8gR-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202503112303.D7g66VSd-lkp@intel.com/

FYI, You don't add "Reported-by" and "Closes" tags for kernel test robot
reports for previous versions of a patch set.

It even says that in the report:

   If you fix the issue in a separate patch/commit (i.e. not just a new version of
   the same patch/commit), kindly add following tags
   | Reported-by: kernel test robot <lkp@...el.com>
   | Closes: https://lore.kernel.org/oe-kbuild-all/202503112205.joXgt8gR-lkp@intel.com/

"not just a new version of the same patch/commit"


> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> ---
>  Changes in v6:
>   - Protect module_delta by RCU.
>   - Make nop make_mod_delta() for CONFIG_MODULES=n.
>   - Rebased on linux-trace/for-next.
>  Changes in v4:
>   - Move module_delta to trace_array again.
>   - Use bsearch for lookup module_delta.
>   - Revert the boolean logic to avoid '!',
>   - Fix !CONFIG_MODULES compile errors.
> ---
>  kernel/trace/trace.c        |  133 +++++++++++++++++++++++++++++++++++++++++--
>  kernel/trace/trace.h        |    8 +++
>  kernel/trace/trace_output.c |    4 +
>  3 files changed, 138 insertions(+), 7 deletions(-)
>