linux-kernel - Re: [PATCH] perf bpf-filter: Fix a parsing error with comma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174293217243.2401011.8039718227768171802.b4-ty@kernel.org>
Date: Tue, 25 Mar 2025 12:49:32 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>, 
 Ian Rogers <irogers@...gle.com>, Kan Liang <kan.liang@...ux.intel.com>, 
 Namhyung Kim <namhyung@...nel.org>
Cc: Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, 
 Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>, 
 LKML <linux-kernel@...r.kernel.org>, linux-perf-users@...r.kernel.org, 
 Sally Shi <sshii@...gle.com>
Subject: Re: [PATCH] perf bpf-filter: Fix a parsing error with comma

On Fri, 07 Mar 2025 14:09:21 -0800, Namhyung Kim wrote:
> The previous change to support cgroup filters introduced a bug that
> pathname can include commas.  It confused the lexer to treat an item and
> the trailing comma as a single token.  And it resulted in a parse error:
> 
>   $ sudo perf record -e cycles:P --filter 'period > 0, ip > 64' -- true
>   perf_bpf_filter: Error: Unexpected item: 0,
>   perf_bpf_filter: syntax error, unexpected BFT_ERROR, expecting BFT_NUM
> 
> [...]
Applied to perf-tools-next, thanks!

Best regards,
Namhyung