linux-kernel - Re: [PATCH] soc: qcom: pmic_glink_altmode: fix spurious DP hotplug events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-Jr7MifpkR8cL5B@hovoldconsulting.com>
Date: Tue, 25 Mar 2025 09:40:12 +0100
From: Johan Hovold <johan@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Johan Hovold <johan+linaro@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Clayton Craft <clayton@...ftyguy.net>
Subject: Re: [PATCH] soc: qcom: pmic_glink_altmode: fix spurious DP hotplug
 events

On Mon, Mar 24, 2025 at 08:21:10PM +0100, Konrad Dybcio wrote:
> On 3/24/25 2:24 PM, Johan Hovold wrote:
> > The PMIC GLINK driver is currently generating DisplayPort hotplug
> > notifications whenever something is connected to (or disconnected from)
> > a port regardless of the type of notification sent by the firmware.
> 
> Yikes!
> 
> Acked-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> 
> That said, I'm hoping there isn't any sort of "port is full of water,
> emergency" messages that we should treat as "unplug" though..

Seems a bit far fetched, but I guess only you guys inside Qualcomm can
try to figure that out.

An alternative could be to cache the hpd_state regardless of the svid
and only forward changes. But perhaps the hpd_state bit is only valid
for DP notifications.

Johan