linux-kernel - Re: [v6] dma-engine: sun4i: Simplify error handling in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGRGNgVcPRJB+sx_5g-+CLJih4vTWU-FrqiRbvVQ07219WBZPA@mail.gmail.com>
Date: Wed, 26 Mar 2025 00:04:10 +1100
From: Julian Calaby <julian.calaby@...il.com>
To: Csókás Bence <csokas.bence@...lan.hu>
Cc: Markus Elfring <Markus.Elfring@....de>, dmaengine@...r.kernel.org, 
	linux-sunxi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	LKML <linux-kernel@...r.kernel.org>, Chen-Yu Tsai <wens@...nel.org>, 
	Chen-Yu Tsai <wens@...e.org>, Christophe Jaillet <christophe.jaillet@...adoo.fr>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, 
	Vinod Koul <vkoul@...nel.org>
Subject: Re: [v6] dma-engine: sun4i: Simplify error handling in probe()

Hi Bence,

On Tue, Mar 25, 2025 at 11:39 PM Csókás Bence <csokas.bence@...lan.hu> wrote:
>
> Hi Julian,
>
> On 2025. 03. 25. 13:20, Julian Calaby wrote:

[snip]

> > Bence Csókás, (I hope I've got the order of your names correct)
>
> Either order works, Bence is the given name, and Csókás is the family
> name (surname). Hungarian and Japanese order follows the scientific
> "Surname, Given Name(s)" order, but commas broke many tools, including
> Git < v2.46, and b4, so I switched to the germanic "Firstname Lastname"
> format.

Thanks for that, I'll try to keep that in mind!

[snip]

> Lastly, to all other adressees, sorry for the spam. So let's end this
> meta-discussion here and keep the rest of the conversation professional,
> reasoning about the technicals.

And this is why I was so hessitant to step in here.

Getting back to that, your patch looks good to me and it's awesome how
the devm_ functions and their frends can simplify things.

I'm going to point out that this does swap the clock enable and reset
deassert, but I'm assuming that is harmless.

Reviewed-by: Julian Calaby <julian.calaby@...il.com>

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/