linux-kernel - Re: [PATCH 2/5] dt-bindings: net: Add MTIP L2 switch description (fec,mtip-switch.yaml)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d3fbe0b-f566-4615-a5df-a8f3b4544c3b@kernel.org>
Date: Tue, 25 Mar 2025 13:43:04 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lukasz Majewski <lukma@...x.de>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 davem@...emloft.net, Andrew Lunn <andrew+netdev@...n.ch>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Richard Cochran <richardcochran@...il.com>,
 netdev@...r.kernel.org, Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH 2/5] dt-bindings: net: Add MTIP L2 switch description
 (fec,mtip-switch.yaml)

On 25/03/2025 13:39, Lukasz Majewski wrote:
> Hi Krzysztof,
> 
>> On 25/03/2025 13:15, Lukasz Majewski wrote:
>>> Hi Krzysztof,
>>>   
>>>> On 25/03/2025 12:57, Lukasz Majewski wrote:  
>>>>> This patch provides description of the MTIP L2 switch available in
>>>>> some NXP's SOCs - imx287, vf610.
>>>>>
>>>>> Signed-off-by: Lukasz Majewski <lukma@...x.de>
>>>>> ---
>>>>>  .../bindings/net/fec,mtip-switch.yaml         | 160
>>>>> ++++++++++++++++++    
>>>>
>>>> Use compatible as filename.  
>>>
>>> I've followed the fsl,fec.yaml as an example. This file has
>>> description for all the device tree sources from fec_main.c  
>>
>>
>> That's a 14 year old binding, so clear antipattern.
> 
> For some reason it is still there...

And it will be there for very long time. Bindings are not removed just
because they are old, because they are an ABI. That's still not a reason
to use something old as starting point.

It's the same with drivers, although driver can be easier changed and
old pattern can be dropped. You cannot easily drop old, anti-patterns
from the binding.

Best regards,
Krzysztof