linux-kernel - Re: [PATCH RESEND 0/5] HID: multitouch: Add support for Touch Bars on x86 MacBook Pros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a556q6xw4grdi7bfjtxr3pgwd4xlkgwnl2n5ucpsu3q5wo2skv@tcouud5sodaf>
Date: Tue, 25 Mar 2025 14:13:57 +0100
From: Benjamin Tissoires <bentiss@...nel.org>
To: Jiri Kosina <jikos@...nel.org>
Cc: Aditya Garg <gargaditya08@...e.com>, 
	Benjamin Tissoires <benjamin.tissoires@...hat.com>, Kerem Karabay <kekrby@...il.com>, 
	Orlando Chamberlain <orlandoch.dev@...il.com>, Aun-Ali Zaidi <admin@...eit.net>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: Re: [PATCH RESEND 0/5] HID: multitouch: Add support for Touch Bars
 on x86 MacBook Pros

On Mar 25 2025, Jiri Kosina wrote:
> On Mon, 10 Mar 2025, Aditya Garg wrote:
> 
> > Hi all!
> > 
> > This patch series aims to improve the Touch Bar support for x86 Macs.
> > 
> > Recently, the hid-appletb-kbd and hid-appletb-bl drivers were upstreamed
> > into the Linux kernel [1]. They enabled the Touch Bar to display a
> > predefined set of media and function keys, exactly the same it does on
> > Windows Bootcamp.
> > 
> > Now we are about to get support added for the DRM mode of the Touch Bar
> > as well [2].
> > 
> > The DRM mode enables the Touch Bar to act as a second display,
> > just like macOS. So now you can add a widget, put a clock or anything
> > else on the Touch Bar as long as you can develop a daemon.
> > 
> > Now via these patches, in the DRM mode, we can use the Touch Bar as a
> > touch screen. The Touch Bar seems to be not compliant with the HID spec,
> > thus via these patches several tweaks have been done under the cover of
> > a single quirk, MT_QUIRK_APPLE_TOUCHBAR.
> > 
> > For the case of T2 Macs, apple-bce [3], the driver for the T2 Security
> > Chip is also needed for all the peripherals, including the Touch Bar
> > to work. It is still WIP, and will be subsequently sent later to the
> > appropriate tree. Till then, I'll suggest for get the driver from [3],
> > or more preferably, get Linux support from https://t2linux.org/.
> 
> Benjamin, could you please Ack this series?

Nitpick on patch 5.

Patches 1-4 are:
Acked-by: Benjamin Tissoires <bentiss@...nel.org>

Cheers,
Benjamin