linux-kernel - linux-6.14/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c bug report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AS8PR02MB10217E34D616B6F5213660E1E9CA62@AS8PR02MB10217.eurprd02.prod.outlook.com>
Date: Wed, 26 Mar 2025 19:16:06 +0000
From: David Binderman <dcb314@...mail.com>
To: "even.xu@...el.com" <even.xu@...el.com>, "xinpeng.sun@...el.com"
	<xinpeng.sun@...el.com>, "jikos@...nel.org" <jikos@...nel.org>,
	"bentiss@...nel.org" <bentiss@...nel.org>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: linux-6.14/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c bug
 report

Hello there,

Static analyser cppcheck says:

linux-6.14/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c:298:24: style: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]

Source code is

        if (!config->sgls[i] | !config->sgls_nent[i])

Perhaps || was intended instead of | ?

Regards

David Binderman