linux-kernel - RE: linux-6.14/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c bug report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6098047C9EF4523F22119E45F4A12@IA1PR11MB6098.namprd11.prod.outlook.com>
Date: Thu, 27 Mar 2025 00:58:24 +0000
From: "Xu, Even" <even.xu@...el.com>
To: David Binderman <dcb314@...mail.com>, "Sun, Xinpeng"
	<xinpeng.sun@...el.com>, "jikos@...nel.org" <jikos@...nel.org>,
	"bentiss@...nel.org" <bentiss@...nel.org>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: linux-6.14/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
 bug report

Hi, David,

Thanks for reminder!
This issue already had patch fix at 2/13:  https://lore.kernel.org/linux-input/20250213024021.2477473-1-even.xu@intel.com/

Hi, Jiri,

I didn't find this patch in latest v6.14-rc7, would you mind help double check which branch this patch got applied?
Thanks!

Best Regards,
Even Xu

> -----Original Message-----
> From: David Binderman <dcb314@...mail.com>
> Sent: Thursday, March 27, 2025 3:16 AM
> To: Xu, Even <even.xu@...el.com>; Sun, Xinpeng <xinpeng.sun@...el.com>;
> jikos@...nel.org; bentiss@...nel.org; linux-input@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: linux-6.14/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c bug report
> 
> Hello there,
> 
> Static analyser cppcheck says:
> 
> linux-6.14/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c:298:24: style:
> Boolean result is used in bitwise operation. Clarify expression with parentheses.
> [clarifyCondition]
> 
> Source code is
> 
>         if (!config->sgls[i] | !config->sgls_nent[i])
> 
> Perhaps || was intended instead of | ?
> 
> Regards
> 
> David Binderman
>