linux-kernel - Re: [PATCH] riscv/kexec_file: Fix comment in purgatory relocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tt7fk1nc.fsf@all.your.base.are.belong.to.us>
Date: Wed, 26 Mar 2025 20:55:19 +0100
From: Björn Töpel <bjorn@...nel.org>
To: Yao Zi <ziyao@...root.org>, Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Alexandre Ghiti <alex@...ti.fr>, Andrew Jones <ajones@...tanamicro.com>,
 Ying Sun <sunying@...c.iscas.ac.cn>, Arnd Bergmann <arnd@...db.de>, Yao Zi
 <ziyao@...root.org>, Kent Overstreet <kent.overstreet@...ux.dev>, Li
 Zhengyu <lizhengyu3@...wei.com>
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv/kexec_file: Fix comment in purgatory relocator

Yao Zi <ziyao@...root.org> writes:

> Apparently sec_base doesn't mean relocated symbol value, which seems a
> copy-pasting error in the comment. Assigned with the address of section
> indexed by sym->st_shndx, it should represent base address of the
> relevant section. Let's fix the comment to avoid possible confusion.
>
> Fixes: 838b3e28488f ("RISC-V: Load purgatory in kexec_file")
> Signed-off-by: Yao Zi <ziyao@...root.org>

Reviewed-by: Björn Töpel <bjorn@...osinc.com>