[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250326073450.57648-2-ziyao@disroot.org>
Date: Wed, 26 Mar 2025 07:34:51 +0000
From: Yao Zi <ziyao@...root.org>
To: Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Alexandre Ghiti <alex@...ti.fr>,
Andrew Jones <ajones@...tanamicro.com>,
Ying Sun <sunying@...c.iscas.ac.cn>,
Arnd Bergmann <arnd@...db.de>,
Yao Zi <ziyao@...root.org>,
Kent Overstreet <kent.overstreet@...ux.dev>,
Li Zhengyu <lizhengyu3@...wei.com>
Cc: linux-riscv@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] riscv/kexec_file: Fix comment in purgatory relocator
Apparently sec_base doesn't mean relocated symbol value, which seems a
copy-pasting error in the comment. Assigned with the address of section
indexed by sym->st_shndx, it should represent base address of the
relevant section. Let's fix the comment to avoid possible confusion.
Fixes: 838b3e28488f ("RISC-V: Load purgatory in kexec_file")
Signed-off-by: Yao Zi <ziyao@...root.org>
---
arch/riscv/kernel/elf_kexec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/kernel/elf_kexec.c b/arch/riscv/kernel/elf_kexec.c
index 3c37661801f9..9b8ff87630f6 100644
--- a/arch/riscv/kernel/elf_kexec.c
+++ b/arch/riscv/kernel/elf_kexec.c
@@ -390,7 +390,7 @@ int arch_kexec_apply_relocations_add(struct purgatory_info *pi,
const Elf_Sym *sym; /* symbol to relocate */
unsigned long addr; /* final location after relocation */
unsigned long val; /* relocated symbol value */
- unsigned long sec_base; /* relocated symbol value */
+ unsigned long sec_base; /* relocated section base address */
void *loc; /* tmp location to modify */
sym = (void *)pi->ehdr + symtab->sh_offset;
--
2.49.0
Powered by blists - more mailing lists