linux-kernel - Re: [PATCH 0/10] More Rust bindings for device property reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250326205409.694744-1-andrewjballance@gmail.com>
Date: Wed, 26 Mar 2025 15:54:09 -0500
From: Andrew Ballance <andrewjballance@...il.com>
To: remo@...nzli.dev
Cc: a.hindborg@...nel.org,
	alex.gaynor@...il.com,
	aliceryhl@...gle.com,
	andriy.shevchenko@...ux.intel.com,
	benno.lossin@...ton.me,
	bjorn3_gh@...tonmail.com,
	boqun.feng@...il.com,
	dakr@...nel.org,
	devicetree@...r.kernel.org,
	dirk.behme@...bosch.com,
	djrscally@...il.com,
	gary@...yguo.net,
	gregkh@...uxfoundation.org,
	heikki.krogerus@...ux.intel.com,
	linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	ojeda@...nel.org,
	rafael@...nel.org,
	robh@...nel.org,
	rust-for-linux@...r.kernel.org,
	sakari.ailus@...ux.intel.com,
	saravanak@...gle.com,
	tmgross@...ch.edu
Subject: Re: [PATCH 0/10] More Rust bindings for device property reads 

Hi thanks for sending these in.

On Wed, Mar 26, 2025 at 12:13 PM Remo Senekowitsch Wrote: 
> This is my first time posting to the mailing list, please let me know if
> I did anything wrong.

you probably will have to resubmit in the patch canonical format[1]

I would recomend reading the docs but in summary:
 - all of your patches should have the subsystem in the subject line.
 - patch 6 is missing a commit message
 - commit messages should be written in the imperitive tone
 - a couple of your commit messages give a reason for the changes but
   do not have a summary of the changes
 - for your v2 you should add a diffstat to your cover letter running
   `git format-patch --base=auto --cover-letter` does this automatically
   for you

Andrew


[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format