linux-kernel - Re: [PATCH 01/10] rust: Move property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250326205838.695261-1-andrewjballance@gmail.com>
Date: Wed, 26 Mar 2025 15:58:38 -0500
From: Andrew Ballance <andrewjballance@...il.com>
To: remo@...nzli.dev
Cc: a.hindborg@...nel.org,
	alex.gaynor@...il.com,
	aliceryhl@...gle.com,
	andriy.shevchenko@...ux.intel.com,
	benno.lossin@...ton.me,
	bjorn3_gh@...tonmail.com,
	boqun.feng@...il.com,
	dakr@...nel.org,
	devicetree@...r.kernel.org,
	dirk.behme@...bosch.com,
	djrscally@...il.com,
	gary@...yguo.net,
	gregkh@...uxfoundation.org,
	heikki.krogerus@...ux.intel.com,
	linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	ojeda@...nel.org,
	rafael@...nel.org,
	robh@...nel.org,
	rust-for-linux@...r.kernel.org,
	sakari.ailus@...ux.intel.com,
	saravanak@...gle.com,
	tmgross@...ch.edu
Subject: Re: [PATCH 01/10] rust: Move property_present to property.rs

On Wed, Mar 26, 2025 at 12:13 PM Remo Senekowitsch Wrote: 
> +        // SAFETY: `fwnode_handle` is valid. Its lifetime is tied to `&self`. We
> +        // return a reference instead of an `ARef<FwNode>` because `dev_fwnode()`
> +        // doesn't increment the refcount.
> +        unsafe { &*fwnode_handle.cast() }


this safety comment should say why it is safe to cast from a
struct fwnode_handle* to a *const FwNode

Andrew