linux-kernel - Re: [PATCH] PCI: j721e: Fix the value of linkdown_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250326070124.boluxjcid4ouszqk@uda0492258>
Date: Wed, 26 Mar 2025 12:31:24 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Krzysztof Wilczyński <kw@...ux.com>
CC: Siddharth Vadapalli <s-vadapalli@...com>,
        Bjorn Helgaas
	<helgaas@...nel.org>, <lpieralisi@...nel.org>,
        <vigneshr@...com>, <manivannan.sadhasivam@...aro.org>,
        <robh@...nel.org>, <bhelgaas@...gle.com>, <rogerq@...nel.org>,
        <linux-omap@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <stable@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <srk@...com>
Subject: Re: [PATCH] PCI: j721e: Fix the value of linkdown_irq_regfield for
 J784S4

On Wed, Mar 26, 2025 at 03:54:47PM +0900, Krzysztof Wilczyński wrote:
> Hello,
> 
> [...]
> > > So I guess without this patch, we incorrectly ignore link-down
> > > interrupts on J784S4.  It's good to have a one-sentence motivation
> > > like that somewhere in the commit log that we can pull out and include
> > > in the merge commit log and the pull request.
> > 
> > Yes, we can prepend the following to the existing commit message:
> > "Link down interrupts on J784S4 SoC are missed because..."
> > 
> > resulting in the following updated paragraph in the commit message:
> > Link down interrupts on J784S4 SoC are missed because commit under Fixes
> > assigned the value of 'linkdown_irq_regfield' for the....
> 
> How does this look like?
> 
>   https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/j721e&id=b97b5b8cb603a4ba6b3f7f1b6065fa76e69bdb56
> 
> Let me know if you want any changes.

I will suggest minor changes to the first paragraph of the commit
message resulting in the following paragraph:

Commit under Fixes assigned the value of .linkdown_irq_regfield for the
J784S4 SoC as the "LINK_DOWN" macro corresponding to BIT(1), and as a
result, the Link Down interrupts on J784S4 SoC are missed.

Regards,
Siddharth.