linux-kernel - Re: [PATCH v3] mm/page_alloc: Consolidate unlikely handling in page_expected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c278ba6-c1a2-4ef7-a4ac-48c233dce7a3@linux.dev>
Date: Wed, 26 Mar 2025 17:34:14 +0800
From: Ye Liu <ye.liu@...ux.dev>
To: Markus Elfring <Markus.Elfring@....de>, Ye Liu <liuye@...inos.cn>,
 linux-mm@...ck.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Anshuman Khandual <anshuman.khandual@....com>,
 Sidhartha Kumar <sidhartha.kumar@...cle.com>
Subject: Re: [PATCH v3] mm/page_alloc: Consolidate unlikely handling in
 page_expected_state

在 2025/3/26 16:48, Markus Elfring 写道:
>> Consolidates the handling of
> …
>> This change simplifies
> …
>> ---
>> V3: Delete 'This patch'.
> How good does such information fit to the wording requirement “imperative mood”?
> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n94

How about this?

Consolidate the handling of unlikely conditions in the page_expected_state
function to reduce code duplication and improve readability.

Move the logic for handling __PG_HWPOISON flags from the check_new_page_bad
function to the page_expected_state function, and remove check_new_page_bad.

Call bad_page directly from the check_new_page function if the page has
unexpected flags.

Simplify the code by reducing the number of functions and centralizing the
handling of unlikely conditions.

> …
>> ---
>> ---
>>  mm/page_alloc.c | 24 ++++++++----------------
> How do you think about to omit redundant marker lines?

---  delete this one？
---
 mm/page_alloc.c | 24 ++++++++----------------

like this ?

V2: return true instead of false in the PageHWPoison branch.
---
 mm/page_alloc.c | 24 ++++++++----------------

Thanks for pointing out the formatting issue.
I would like to get your approval on the above changes before I send patch v4.

> Regards,
> Markus