linux-kernel - Re: [PATCH RESEND 5/5] HID: multitouch: add device ID for Apple Touch Bar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7rsn5334-npo6-408r-8442-6o3qo3qp05q7@xreary.bet>
Date: Wed, 26 Mar 2025 10:54:53 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Aditya Garg <gargaditya08@...e.com>
cc: Aditya Garg <adityagarg1208@...il.com>, 
    Benjamin Tissoires <bentiss@...nel.org>, 
    "admin@...eit.net" <admin@...eit.net>, 
    "benjamin.tissoires@...hat.com" <benjamin.tissoires@...hat.com>, 
    "kekrby@...il.com" <kekrby@...il.com>, 
    "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, 
    "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
    "orlandoch.dev@...il.com" <orlandoch.dev@...il.com>
Subject: Re: [PATCH RESEND 5/5] HID: multitouch: add device ID for Apple
 Touch Bar

On Tue, 25 Mar 2025, Aditya Garg wrote:

> >>> Yes I can move hid_find_field to the original location as well. But, 
> >>> I would not want to devm_kzalloc as well unnecessarily if the 
> >>> touchbar is in the basic mode instead of drm mode which will cause 
> >>> this -ENODEV to be executed right?
> >> 
> >> It shouldn't matter. hid_core calls devres_open_group() before calling
> >> .probe(), and calls devres_release_group() on failure. So yes, we'll
> >> allocate a piece of memory and release it after, but it's not something
> >> uncommon.
> > 
> > Fair. I'll send a v2
> 
> I've sent a v2 from my gmail address. Outlook is being too fussy these 
> days, so hopefully I don't have to sign off twice using gmail as well as 
> outlook.

Thanks. Please always make sure that either in the cover letter or in the 
individual patches you otline the differences between individual patch 
submissions.

-- 
Jiri Kosina
SUSE Labs